Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new projectFromId Vitessce function to get view cooordinates #909

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Use new projectFromId Vitessce function to get view cooordinates #909

merged 1 commit into from
Oct 9, 2023

Conversation

ivababukova
Copy link
Member

@ivababukova ivababukova commented Oct 9, 2023 •
edited by gerbeldo
Loading

Description

Vitessce v3 uses a new function called projectfromId to get the correct cell coordinates for the cellInfo box. When upgrading Vitessce, I fixed the Embedding, but I forgot to fix the function name for the Heatmap. This doesn't error out, because function project still exists, it just does other stuff.

Fixes hms-dbmi-cellenics/issues#74

Details

URL to issue

N/A

Link to staging deployment URL (or set N/A)

N/A

Links to any PRs or resources related to this PR

Integration test branch

master

Merge checklist

Your changes will be ready for merging after all of the steps below have been completed.

Code updates

Have best practices and ongoing refactors being observed in this PR

  • Migrated any selector / reducer used to the new format.
  • All new dependency licenses have been checked for compatibility.

Manual/unit testing

  • Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
  • Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
  • Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing

You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

  • Started end-to-end tests on the latest commit.

Documentation updates

  • Relevant Github READMEs updated or no GitHub README updates required.
  • Relevant Wiki pages created/updated or no Wiki updates required.

Optional

  • Staging environment is unstaged before merging.
  • Photo of a cute animal attached to this PR.

@ivababukova ivababukova added the safe to run Sensitive jobs are safe to be run label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

📦 Next.js Bundle Analysis for ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/experiments/[experimentId]/data-exploration 515.9 KB (🟡 +7 B) 1.07 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #909 (3615147) into master (da679ad) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   85.60%   85.59%   -0.01%     
==========================================
  Files         548      548              
  Lines       10169    10169              
  Branches     2134     2134              
==========================================
- Hits         8705     8704       -1     
- Misses       1411     1412       +1     
  Partials       53       53
Files Coverage Δ
...omponents/data-exploration/heatmap/HeatmapPlot.jsx 89.32% <0.00%> (ø)

... and 1 file with indirect coverage changes

@gerbeldo gerbeldo mentioned this pull request Oct 9, 2023
Merged
10 tasks
gerbeldo
gerbeldo approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@gerbeldo gerbeldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in staging, works.

@gerbeldo gerbeldo merged commit 7c5910c into hms-dbmi-cellenics:master Oct 9, 2023
@gerbeldo gerbeldo deleted the use-correct-project-func branch October 9, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerbeldo gerbeldo gerbeldo approved these changes

Assignees
No one assigned
Labels
safe to run Sensitive jobs are safe to be run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cell ID box in heatmap does not move when hovering
2 participants
@ivababukova @gerbeldo